Do non-anonymous DockerHub pulls on CI (anonymous pulls have stricter…

… pull limits)
cyber-dojo-retired · Oct 8, 2020 · f3319b3 · f3319b3
1 parent 2b013ed
commit f3319b3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -10,7 +10,10 @@ jobs:
           command: |
             export AVATARS_COVERAGE=off
             export AVATARS_DEMO=off
+            # DOCKER_USER, DOCKER_PASS are in the context
+            echo "${DOCKER_PASS}" | docker login --username "${DOCKER_USER}" --password-stdin
             ./build_test_publish.sh
+            docker logout            
 
   deploy-to-beta:
     docker:

diff --git a/sh/on_ci_publish_tagged_images.sh b/sh/on_ci_publish_tagged_images.sh
@@ -14,11 +14,8 @@ on_ci_publish_tagged_images()
   local -r image="$(image_name)"
   local -r sha="$(image_sha)"
   local -r tag="${sha:0:7}"
-  # DOCKER_USER, DOCKER_PASS are in ci context
-  echo "${DOCKER_PASS}" | docker login --username "${DOCKER_USER}" --password-stdin
   docker push "${image}:latest"
   docker push "${image}:${tag}"
-  docker logout
 }
 
 # - - - - - - - - - - - - - - - - - - - - - - - -