Skip to content

Commit

Permalink
configure: fix v8 overriding commands on build
Browse files Browse the repository at this point in the history
V8 seems to ignore the default value for want_separate_host_toolset and
would override it at build time. Instead always explicitly set the value.

Fixes nodejs#7833
  • Loading branch information
trevnorris committed Jul 2, 2014
1 parent c7c904b commit 449ffec
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions configure
Original file line number Diff line number Diff line change
Expand Up @@ -473,6 +473,8 @@ def configure_node(o):

if target_arch != host_arch and not options.without_snapshot:
o['variables']['want_separate_host_toolset'] = 1
else:
o['variables']['want_separate_host_toolset'] = 0

if target_arch == 'arm':
configure_arm(o)
Expand Down

0 comments on commit 449ffec

Please sign in to comment.