Skip to content

Commit

Permalink
Logging fixes for verbosity (elastic#6240)
Browse files Browse the repository at this point in the history
* Add a check for the `verbose` flag, before going back to Info.
* Revert to using `warning` in the configuration instead of `warn`. It seems that
  we have always used `warning`.

Fixes elastic#6239.
  • Loading branch information
tsg authored and andrewkroh committed Jan 31, 2018
1 parent 1a6a5cd commit df4e23c
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion libbeat/logp/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ package logp
type Config struct {
Beat string `config:",ignore"` // Name of the Beat (for default file name).
JSON bool `config:"json"` // Write logs as JSON.
Level Level `config:"level"` // Logging level (error, warn, info, debug).
Level Level `config:"level"` // Logging level (error, warning, info, debug).
Selectors []string `config:"selectors"` // Selectors for debug level logging.

toObserver bool
Expand Down
2 changes: 1 addition & 1 deletion libbeat/logp/configure/logging.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ func applyFlags(cfg *logp.Config) {
if toStderr {
cfg.ToStderr = true
}
if cfg.Level > logp.InfoLevel {
if cfg.Level > logp.InfoLevel && verbose {
cfg.Level = logp.InfoLevel
}
for _, selectors := range debugSelectors {
Expand Down
4 changes: 2 additions & 2 deletions libbeat/logp/core_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -81,12 +81,12 @@ func TestGlobalLoggerLevel(t *testing.T) {
assert.Equal(t, "info", logs[0].Message)
}

Warn("warn")
Warn("warning")
logs = ObserverLogs().TakeAll()
if assert.Len(t, logs, 1) {
assert.Equal(t, zap.WarnLevel, logs[0].Level)
assert.Equal(t, "", logs[0].LoggerName)
assert.Equal(t, "warn", logs[0].Message)
assert.Equal(t, "warning", logs[0].Message)
}

Err("error")
Expand Down
2 changes: 1 addition & 1 deletion libbeat/logp/level.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ const (
var levelStrings = map[Level]string{
DebugLevel: "debug",
InfoLevel: "info",
WarnLevel: "warn",
WarnLevel: "warning",
ErrorLevel: "error",
CriticalLevel: "critical",
}
Expand Down

0 comments on commit df4e23c

Please sign in to comment.