Always install demo certs if configured with demo certs #62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the demo installer to always install the demo certs into the
config/folder even if the following settings are already present inopensearch.ymlBy ensuring that the files are always copied, it resolves an issue seen in the helm-charts repo where the values are already present in
opensearch.ymlbut the certs are not written to theconfig/folder in the event that the opensearch process dies on one of the pods and is replaced. The reason for that is that it goes through the installation script and aborts saying that security is already configured.Issues Resolved
Resolves: opensearch-project#5044
Helm Charts: opensearch-project/helm-charts#680
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.