Add e2e test to show integration of serialization and deserialization changes to User to include the attribute map #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attempt reading injected attributes in RolesInjector add custom attributes to user information in thread context add more logging to injectUserAndRoles add debugging statements update serialization to include only custom attribute name revert changes to RolesInjector revert changes to UserInjector revert changes to SecurityFilter Signed-off-by: Mark Boyd <mark.boyd@gsa.gov> update setUserInfoInThreadContext to base64 encode the serialized map of user custom attributes Signed-off-by: Mark Boyd <mark.boyd@gsa.gov> add null tenant to user context when none is available Signed-off-by: Mark Boyd <mark.boyd@gsa.gov> Immutable user object (opensearch-project#5212) Signed-off-by: Nils Bandener <nils.bandener@eliatra.com> Signed-off-by: Mark Boyd <mark.boyd@gsa.gov> apply spotless formatting Signed-off-by: Mark Boyd <mark.boyd@gsa.gov>
…en requested tenant is empty Signed-off-by: Mark Boyd <mark.boyd@gsa.gov>
Signed-off-by: Mark Boyd <mark.boyd@gsa.gov>
Signed-off-by: Mark Boyd <mark.boyd@gsa.gov>
Signed-off-by: Mark Boyd <mark.boyd@gsa.gov>
…Utils Signed-off-by: Mark Boyd <mark.boyd@gsa.gov>
…control whether user attributes are serialized Signed-off-by: Mark Boyd <mark.boyd@gsa.gov>
…k if user attribute serialization is enabled before adding serialized user attributes to the thread context Signed-off-by: Mark Boyd <mark.boyd@gsa.gov>
Signed-off-by: Mark Boyd <mark.boyd@gsa.gov>
…t consistent Signed-off-by: Mark Boyd <mark.boyd@gsa.gov>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Steps to test:
./gradlew publishToMavenLocalto publish the common-utils changes to your local maven repository where they can be picked up by the security plugin./gradlew :opensearch-sample-resource-plugin:integrationTest --tests SampleResourcePluginTests.testUserSerializationAndDeserialization -iObserve the debug statement with Parsed User in the logs:
Note: The changes in this PR are WIP and for demonstration purposes, the test should ideally add some assertions but some application logic may need to updated to use the log out the parsed user and then the test can assert the existence of certain log lines.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.