Revert "fix file and cmd secret source inputs (dagger#6845)" (dagger#…

…7271) This reverts commit 5fbe1b2.
cwlbraa · May 7, 2024 · e366bdf · e366bdf
1 parent bd09563
commit e366bdf
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/.changes/unreleased/Breaking-20240507-134020.yaml b/.changes/unreleased/Breaking-20240507-134020.yaml
@@ -0,0 +1,6 @@
+kind: Breaking
+body: Remove space stripping from secret arguments
+time: 2024-05-07T13:40:20.158396621-03:00
+custom:
+  Author: marcosnils
+  PR: "7271"
diff --git a/cmd/dagger/flags.go b/cmd/dagger/flags.go
@@ -369,15 +369,15 @@ func (v *secretValue) Get(ctx context.Context, c *dagger.Client, _ *dagger.Modul
 		if err != nil {
 			return nil, fmt.Errorf("failed to read secret file %q: %w", v.sourceVal, err)
 		}
-		plaintext = strings.TrimSpace(string(filePlaintext))
+		plaintext = string(filePlaintext)
 
 	case commandSecretSource:
 		// #nosec G204
 		stdoutBytes, err := exec.CommandContext(ctx, "sh", "-c", v.sourceVal).Output()
 		if err != nil {
 			return nil, fmt.Errorf("failed to run secret command %q: %w", v.sourceVal, err)
 		}
-		plaintext = strings.TrimSpace(string(stdoutBytes))
+		plaintext = string(stdoutBytes)
 
 	default:
 		return nil, fmt.Errorf("unsupported secret arg source: %q", v.secretSource)