Skip to content

Commit

Permalink
add better_sqlite3 called from main
Browse files Browse the repository at this point in the history
  • Loading branch information
cwellsx committed Oct 29, 2022
1 parent 60e1a20 commit e024859
Show file tree
Hide file tree
Showing 7 changed files with 603 additions and 69 deletions.
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,14 @@
> and therefore its `version` is NOT changed when any updates are made to this template.
> Instead, updates to this template are shown only in this CHANGELOG (and in the Git history).
### 2022-10-21

- Begin to use SQLite -- use the `fix_electron20_build` branch of a fork of `better-sqlite3`
because the mainstream version doesn't yet support Electron 20:
- https://github.com/WiseLibs/better-sqlite3/issues/867#issuecomment-1277766794
- https://github.com/WiseLibs/better-sqlite3/pull/870
- https://github.com/neoxpert/better-sqlite3/tree/fix_electron20_build

### 2022-10-16

- Create the [`dotnet` branch](https://github.com/cwellsx/electron_forge_template/tree/dotnet)
Expand Down
21 changes: 21 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
This project includes SQLite via the `better-sqlite3` package.

Apparently it needs to be rebuilt for Electron -- a standard prebuild for Node.js won't work --
even when it's accessed from the main and not the renderer process.

To install the necessary tools I simply installed the latest version of Node.js
from https://nodejs.org/en/download/current/
with the "Windows build tools" option enabled.
I already had MSVC 2019 and 2015 (Community Edition) installed.

I thought I might need this plugin but apparently it works without:

```json
[
"@timfish/forge-externals-plugin",
{
"externals": ["better-sqlite3"],
"includeDeps": true
}
]
```
Loading

0 comments on commit e024859

Please sign in to comment.