Skip to content

Add TemplateData to opts #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 26, 2020

Conversation

titolins
Copy link
Contributor

@titolins titolins commented Nov 25, 2020

Closes #139

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@titolins
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link
Collaborator

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@titolins titolins changed the title Add TemplateData to opts #139 Add TemplateData to opts Nov 25, 2020
@titolins
Copy link
Contributor Author

@googlebot I fixed it.

1 similar comment
@titolins
Copy link
Contributor Author

@googlebot I fixed it.

@coveralls
Copy link

coveralls commented Nov 25, 2020

Coverage Status

Coverage increased (+0.2%) to 96.296% when pulling e74f1fc on titolins:feature/allow_load_from_data into f15877a on cweill:develop.

@titolins titolins force-pushed the feature/allow_load_from_data branch from 65b11e6 to d71901e Compare November 25, 2020 23:29
@googlebot
Copy link
Collaborator

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Contributor signed Google CLA and removed cla: no labels Nov 25, 2020
@titolins
Copy link
Contributor Author

@googlebot I fixed it.

@cweill cweill self-requested a review December 26, 2020 22:57
Copy link
Owner

@cweill cweill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for the contribution @titolins

@cweill cweill merged commit 49dfdf5 into cweill:develop Dec 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Contributor signed Google CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow loading from externally embedded template data
4 participants