forked from grafana/pyroscope
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request grafana#123 from pyroscope-io/segment-bug-fixes
Segment Tree bug fixes
- Loading branch information
Showing
8 changed files
with
270 additions
and
38 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,123 @@ | ||
| package segment | ||
|
|
||
| import ( | ||
| "log" | ||
| "math/big" | ||
| "math/rand" | ||
| "time" | ||
|
|
||
| . "github.com/onsi/ginkgo" | ||
| . "github.com/onsi/gomega" | ||
| "github.com/pyroscope-io/pyroscope/pkg/testing" | ||
| ) | ||
|
|
||
| type datapoint struct { | ||
| t time.Time | ||
| samples uint64 | ||
| r *big.Rat | ||
| } | ||
|
|
||
| type storageMock struct { | ||
| resolution time.Duration | ||
| data []datapoint | ||
| } | ||
|
|
||
| func newMock(resolution time.Duration) *storageMock { | ||
| return &storageMock{ | ||
| resolution: resolution, | ||
| data: []datapoint{}, | ||
| } | ||
| } | ||
|
|
||
| func (sm *storageMock) Put(st, et time.Time, samples uint64) { | ||
| st, et = normalize(st, et) | ||
| fullDur := et.Sub(st) / sm.resolution | ||
| for t := st; t.Before(et); t = t.Add(sm.resolution) { | ||
| d := datapoint{ | ||
| t: t, | ||
| samples: samples, | ||
| r: big.NewRat(int64(samples), int64(fullDur)), | ||
| } | ||
|
|
||
| sm.data = append(sm.data, d) | ||
| } | ||
| } | ||
|
|
||
| func (sm *storageMock) Get(st, et time.Time, cb func(depth int, samples uint64, t time.Time, r *big.Rat)) { | ||
| st, et = normalize(st, et) | ||
| for _, d := range sm.data { | ||
| if !d.t.Before(st) && !d.t.Add(sm.resolution).After(et) { | ||
| cb(0, 1, d.t, d.r) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| func fuzzTest(writeSize func() int) { | ||
| s := New(10*time.Second, 10) | ||
| m := newMock(10 * time.Second) | ||
|
|
||
| r := rand.New(rand.NewSource(123)) | ||
|
|
||
| for k := 0; k < 20; k++ { | ||
| maxStartTime := r.Intn(5000) | ||
| for i := 0; i < r.Intn(200); i++ { | ||
| sti := r.Intn(maxStartTime) * 10 | ||
| st := testing.SimpleTime(sti) | ||
| et := testing.SimpleTime(sti + writeSize()) | ||
| dur := et.Sub(st) | ||
| // this is not exactly a fair game, but we have to adjust for | ||
| samples := uint64(r.Intn(10)) * uint64(dur/(10*time.Second)) | ||
|
|
||
| m.Put(st, et, samples) | ||
| s.Put(st, et, samples, func(depth int, t time.Time, r *big.Rat, addons []Addon) { | ||
| log.Println(depth, r, dur) | ||
| }) | ||
| } | ||
| mSum := big.NewRat(0, 1) | ||
| sSum := big.NewRat(0, 1) | ||
| for i := 0; i < r.Intn(100); i++ { | ||
| sti := r.Intn(100) * 10 | ||
| st := testing.SimpleTime(sti) | ||
| et := testing.SimpleTime(sti + r.Intn(100)*10) | ||
|
|
||
| m.Get(st, et, func(depth int, samples uint64, t time.Time, r *big.Rat) { | ||
| mSum.Add(mSum, r.Mul(r, big.NewRat(int64(samples), 1))) | ||
| }) | ||
|
|
||
| s.Get(st, et, func(depth int, samples uint64, t time.Time, r *big.Rat) { | ||
| sSum.Add(sSum, r.Mul(r, big.NewRat(int64(samples), 1))) | ||
| }) | ||
| } | ||
| mSumF, _ := mSum.Float64() | ||
| log.Println("m:", mSum, mSumF) | ||
|
|
||
| sSumF, _ := sSum.Float64() | ||
| log.Println("s:", sSum, sSumF) | ||
|
|
||
| Expect(mSum.Cmp(sSum)).To(Equal(0)) | ||
| } | ||
| // Expect(1).To(Equal(0)) | ||
| } | ||
|
|
||
| // See https://github.com/pyroscope-io/pyroscope/issues/28 for more context | ||
| var _ = Describe("segment", func() { | ||
| Context("fuzz tests", func() { | ||
| Context("writes are 10 second long", func() { | ||
| It("works as expected", func(done Done) { | ||
| fuzzTest(func() int { | ||
| return 10 | ||
| }) | ||
| close(done) | ||
| }, 5) | ||
| }) | ||
| Context("writes are different lengths", func() { | ||
| It("works as expected", func(done Done) { | ||
| fuzzTest(func() int { | ||
| return 20 | ||
| // return 1 + rand.Intn(10)*10 | ||
| }) | ||
| close(done) | ||
| }, 5) | ||
| }) | ||
| }) | ||
| }) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.