Skip to content

Commit

Permalink
Temporary fix: Disable custom element experiment check because it hap…
Browse files Browse the repository at this point in the history
…pens too early (ampproject#24529)

There is an init order conflict between experiment framework and logging infra. Disable the call for quick cherry-pick before we do a better fix.

This is a partial rollback of ampproject#24215
  • Loading branch information
cramforce authored and danielrozenberg committed Sep 14, 2019
1 parent 97e2968 commit d34408e
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion src/polyfills.js
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,11 @@ if (self.document) {
// isExperimentOn() must be called after Object.assign polyfill is installed.
// TODO(jridgewell, estherkim): Find out why CE isn't being polyfilled for IE.
if (
isExperimentOn(self, 'custom-elements-v1') ||
// NOTE: isExperimentOn cannot be called this early due to
// a dependency of logging having been initialized.
// This is just a minimal revert of
// https://github.com/ampproject/amphtml/pull/24215
(false && isExperimentOn(self, 'custom-elements-v1')) ||
(getMode().test && !getMode().testIe)
) {
installCustomElements(self);
Expand Down

0 comments on commit d34408e

Please sign in to comment.