Skip to content

Ingest Tarball now with modifiyable ownership #3362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

HereThereBeDragons
Copy link
Contributor

cvmfs_ingest has now 3 new command parameters to control ownership of files ingested:

# either
-u / --user uid
-g / --group gid
# or
-k / -keep-ownership

group can only be applied if also user is given.
if keep-ownership is set, neither user or group can be set

default behavior is to set the new owner to be the cvmfs repo owner

this ownership change only affects files, not directories. directories are always owned by the cvmfs repo owner.
(not sure if we want this.. but there the mechanics for it seems to be not in easy to reach places)

for the swissknife ingest command the new params are (no check is done if they are valid):

-U uid # if set to -1 == keep-ownership
-G gid # if set to -1 == keep-ownership

@HereThereBeDragons HereThereBeDragons added this to the 2.12 milestone Aug 11, 2023
@HereThereBeDragons
Copy link
Contributor Author

Issue #3073

@cernvm-bot
Copy link
Collaborator

linter finished with errors:

Done processing ttest/unittests/t_sync_union_tarball.cc:53:  Missing space after ,  [whitespace/comma] [3]
test/unittests/t_sync_union_tarball.cc:67:  Missing space after ,  [whitespace/comma] [3]
test/unittests/t_sync_union_tarball.cc:81:  Missing space after ,  [whitespace/comma] [3]

@HereThereBeDragons
Copy link
Contributor Author

@cernvm-bot cloudtest

@HereThereBeDragons
Copy link
Contributor Author

ps. there might be some issues with the bash?

Checking storage integrity of just.test.repo ... (may take a while)
Verifying integrity of just.test.repo...
Inspecting log of references
Inspecting tag database
[inspecting catalog] 715afbe1e841fb126189042724dd510c34f23147 at /
no problems found
/usr/bin/cvmfs_server: 2178: return: Illegal number: 
total 15K

and

*** 2) ingesting the tarball again in the directory tar_dir: everything owned by root
/usr/bin/cvmfs_server: 9236: eval: [[: not found
Using auto tag 'generic-2023-08-11T13:54:16Z'
Processing changes...
Waiting for upload of files before committing...
Committing file catalogs...
Wait for all uploads to finish

@cernvm-bot
Copy link
Collaborator

building for cloudtests finished: SUCCESS
https://lcgapp-services.cern.ch/cvmfs-jenkins/job/CvmfsFullBuildDocker/4063/

@cernvm-bot
Copy link
Collaborator

@HereThereBeDragons
Copy link
Contributor Author

@cernvm-bot unittest

@HereThereBeDragons
Copy link
Contributor Author

@cernvm-bot help

@cernvm-bot
Copy link
Collaborator

Syntax: @cernvm-bot subcommand + [args]
Available commands:
help
cpplint
tidy
unittest + [full] + [linux] + [mac]
cloudtest + [full] + [nodestroy] + [cc7] + [cc8] + [container]
all

@HereThereBeDragons
Copy link
Contributor Author

@cernvm-bot tidy

@HereThereBeDragons
Copy link
Contributor Author

@cernvm-bot cloudtest

@cernvm-bot
Copy link
Collaborator

building for cloudtests finished: SUCCESS
https://lcgapp-services.cern.ch/cvmfs-jenkins/job/CvmfsFullBuildDocker/4085/

@cernvm-bot
Copy link
Collaborator

@HereThereBeDragons
Copy link
Contributor Author

@cernvm-bot tidy

Copy link
Contributor

@vvolkl vvolkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@vvolkl vvolkl merged commit 47c91d5 into cvmfs:devel Dec 8, 2023
@HereThereBeDragons HereThereBeDragons deleted the ingest_change_owner_3073 branch December 8, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants