Conversation
guillepinto
requested changes
Dec 17, 2024
Member
guillepinto
left a comment
There was a problem hiding this comment.
The notebook name must be in lower case. The versions of some libraries are also missing.
Member
There was a problem hiding this comment.
Although torchinfo is installed and the call torchsummary is also done, they are never used, I suggest to remove them if they are not going to be used or use summary of torchinfo to see the model modules as in vit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Provide a detailed description of your changes and why they are necessary.
Checklist
Ensure your pull request meets the following requirements:
cross-entropy-loss.ipynb).notebooks/.Linked Issues
List any related issues this pull request addresses.
e.g., "Fixes #123"
Additional Information
Any other information you want to include?
Include any other context, screenshots, or details that might help understand your changes.