Prevent consolidateCompletedTuplets() from breaking complete tuplets#1858
Open
jacobtylerwalls wants to merge 1 commit intocuthbertLab:masterfrom
Open
Prevent consolidateCompletedTuplets() from breaking complete tuplets#1858jacobtylerwalls wants to merge 1 commit intocuthbertLab:masterfrom
consolidateCompletedTuplets() from breaking complete tuplets#1858jacobtylerwalls wants to merge 1 commit intocuthbertLab:masterfrom
Conversation
consolidateCompletedTuplets() from breaking well-formed tuplets
22c8319 to
a67e823
Compare
consolidateCompletedTuplets() from breaking well-formed tupletsconsolidateCompletedTuplets() from breaking complete tuplets
a67e823 to
530f906
Compare
jacobtylerwalls
commented
Jan 26, 2026
| # else: pass | ||
|
|
||
|
|
||
| class TupletSearchState: # pylint: disable=W0201 |
Member
Author
There was a problem hiding this comment.
Happy to move this to another module if this is too exposed (or too confusing with TupletFixer).
The location in the duration module explains why you see stringified annotations or stringified gEBC() calls, because this module can't import note. So that would be ripe for a polish if there's a better location.
530f906 to
30d9355
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1780
Before
consolidateCompletedTuplets()was violating the Hippocractic Oath of tuplet doctors: first, break no well-formed tuplets.In more detail:
While scanning this stream...
the region spanning 1.0 QL from {e8 - e8 - e8} was replaced with a single e4, even though it broke the tuplets it spanned.
The reason was that the algorithm scanned the first e8, determined that it didn't match the pitch of the immediately prior d8, and reset all of the search state.
After
Now, search state is maintained regardless of whether a note is reexpressible or whether it matches the prior note. This way, search state is always cleared when a tuplet is completed, ensuring no candidates for consolidation are identified inside other well-formed tuplets.