Skip to content

Conversation

@LucidityCrash
Copy link
Contributor

I looked at https://developers.home-assistant.io/blog/2024/11/12/options-flow/
and made the suggested changes. Not sure what to do with the self._show_form = False on line 30 though.

@craigbarratt
Copy link
Member

Have you confirmed that this works correctly in HA / HACS (ie, the workflow for web-based settings works correctly)?

Unfortunately I didn't write the config flow code in pyscript, so I'm not sure what the right solution is.

@LucidityCrash
Copy link
Contributor Author

Have you confirmed that this works correctly in HA / HACS (ie, the workflow for web-based settings works correctly)?

Unfortunately I didn't write the config flow code in pyscript, so I'm not sure what the right solution is.

I'm not 100% sure either ... Testing just carried out :

  1. I'd configured it using the config.yaml so I've now removed the 2 entries from that and then removed the integration.
  2. Added the integraton - it and it gave me a dialogue box with the 2 tickboxes in. I ticked them both as per my config.yaml (though I dont have any scripts that access hass variables).
  3. Executed one of my scripts that uses aiohttp and that worked.
  4. Restarted Home assistant and re did 3.
  5. Removed integration, restarted HA, repeated 2 & 3

All looks good to me.

@craigbarratt craigbarratt merged commit e6c7c3b into custom-components:master Mar 17, 2025
1 check passed
@craigbarratt
Copy link
Member

Awesome - thanks for confirming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants