No more images after update 0.1.8 -> 0.1.11 #78

Activity

1. zboersen commented on Jul 7, 2023

   

   zboersen

   on Jul 7, 2023

   Last edited by ogajduse

   More actions

   For anybody facing the same issue, I changed the code in the sensor for feedparser. Now it should show both image en enclosure the right way! Maybe this can be added to the official release as well!

   # Existing code
   
   if "image" in self._inclusions and "image" not in entry_value.keys():
       images = []
       if "summary" in entry.keys():
           images = re.findall(r"<img.+?src=\"(.+?)\".+?>", entry["summary"])
       if images:
           entry_value["image"] = images[0]
       else:
           if "links" in entry.keys():
               images = re.findall(
                   '(?:(?:https?|ftp):\/\/)?[\w/\-?=%.]+\.[\w/\-&?=%.]+', str(entry["links"][1])
               )
           if images:
               entry_value["image"] = images[0]
           else:
               entry_value[
                   "image"
               ] = "https://www.home-assistant.io/images/favicon-192x192-full.png"

   # Modified code
   
   if "image" in self._inclusions and "image" not in entry_value.keys():
       images = []
       if "summary" in entry.keys():
           images = re.findall(r"<img.+?src=\"(.+?)\".+?>", entry["summary"])
       if images:
           entry_value["image"] = images[0]
       else:
           if "enclosures" in entry.keys() and entry["enclosures"]:
               enclosure_url = entry["enclosures"][0].get("url")
               if enclosure_url:
                   entry_value["image"] = enclosure_url
           else:
               if "links" in entry.keys():
                   images = re.findall(
                       '(?:(?:https?|ftp):\/\/)?[\w/\-?=%.]+\.[\w/\-&?=%.]+', str(entry["links"][1])
                   )
               if images:
                   entry_value["image"] = images[0]
               else:
                   entry_value[
                       "image"
                   ] = "https://www.home-assistant.io/images/favicon-192x192-full.png"

   👍React with 👍1Reacted by BebeMischa
2. ogajduse commented on Jul 9, 2023

   

   ogajduse

   on Jul 9, 2023

   Collaborator

   More actions

   I am looking into it in my free time. I also plan to add tests for the integration in #80 to ensure that future releases do not break stuff.
   If anyone finds a way to fix it, do not hesitate to submit a PR.

   👍React with 👍1Reacted by BebeMischa
3. BebeMischa commented on Jul 13, 2023

   

   BebeMischa

   on Jul 13, 2023

   Author

   More actions

   Thanks, @zboersen , it did the trick ;-)
4. ogajduse commented on Jul 26, 2023

   

   ogajduse

   on Jul 26, 2023

   Collaborator

   More actions

   I have the fix. I should publish a new feedparser version with the fix this weekend.

   @BebeMischa @zboersen
   Could you please share the RSS feed URLs that you use and that contain images? That would help me in extending the test coverage.
5. ogajduse commented on Jul 28, 2023

   

   ogajduse

   on Jul 28, 2023

   Last edited by ogajduse

   Collaborator

   More actions

   #81 should fix this issue.
   Could you please try the beta release I did and tell me if images show up for you?
   https://github.com/custom-components/feedparser/releases/tag/0.2.0b0

   If they do not show up, could you please provide the feed URL, so I can investigate?

   Note: #78, #57 and #64 should be addressed and fixed by #81.
6. ogajduse

   linked a pull request that will close this issueShow images based on the envelopes feed parameter #81on Aug 9, 2023
7. ogajduse

   added this to the Release 0.2.0 milestone on Aug 17, 2023