Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable _tweak_price for 3-coin Cryptopools #295

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

allt0ld
Copy link
Collaborator

@allt0ld allt0ld commented Feb 26, 2024

Description

  • Made minor changes to CurveCryptoPool._tweak_price like changing parameter types and adding a few error messages.
  • Most of the lines come from the new test_tweak_price function in test_tricrypto.py, which tests _tweak_price's behavior after a pool experiences donations, an exchange, a deposit, and a withdrawal.

Hygiene checklist

  • Changelog entry
  • Everything public has a Numpy-style docstring
    (modules, public functions, classes, and public methods)
  • Commit history is cleaned-up with minor changes squashed together
    and descriptive commit messages following Tim Pope's style

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant