review: throw an error if the user doesn't have login activity record…

… when getLoginActivity method has been executed.

src/login/login-activity/service.ts

@@ -1,3 +1,4 @@
+import { NotFound } from '@curveball/http-errors';
 import { UserLoginActivityRecord } from 'knex/types/tables.js';
 import db from '../../database.js';
 import { User } from '../../types.js';
@@ -8,10 +9,14 @@ export function reachedMaxAttempts(attempts: number) {
   return attempts >= MAX_FAILED_ATTEMPTS;
 }
 
-async function getLoginActivity(user: User): Promise<UserLoginActivityRecord | undefined> {
-  return await db<UserLoginActivityRecord>('user_login_activity')
+async function getLoginActivity(user: User): Promise<UserLoginActivityRecord> {
+  const loginActivity = await db<UserLoginActivityRecord>('user_login_activity')
     .where({ principal_id: user.id })
     .first();
+
+  if (!loginActivity) throw new NotFound(`Login activity record for user with ID ${user.id} was not found.`);
+
+  return loginActivity;
 }
 
 async function ensureUserLoginActivityRecord(user: User): Promise<void> {
@@ -61,5 +66,5 @@ export async function isAccountLocked(user: User): Promise<boolean> {
   await ensureUserLoginActivityRecord(user);
 
   const loginActivity = await getLoginActivity(user);
-  return !!loginActivity?.account_locked;
+  return !!loginActivity.account_locked;
 }