Skip to content

Updated regex stage with support for text range and multiple line pat… #959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 1, 2022

Conversation

AndreasArvidsson
Copy link
Member

@AndreasArvidsson AndreasArvidsson commented Sep 14, 2022

…terns

Came out of the work on #954
Not really used for anything at the moment but gives us the opportunity to clamp the text range and support multiline regex patterns if we want to.

Checklist

Copy link
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I made some tweaks, because this PR was only partially adding support for multi-line regexes. After these tweaks, a modifier stage can just override expandRangeForSearch and multi-line regexes should work

If you're happy with the tweaks merge away

@AndreasArvidsson AndreasArvidsson merged commit c958b50 into main Oct 1, 2022
@AndreasArvidsson AndreasArvidsson deleted the regCleanUp branch October 1, 2022 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants