Added tests for visible ranges(scroll, fold) #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pokey
previously approved these changes
Feb 2, 2022
There was a problem hiding this comment.
This looks really nice; thanks for following up on this stuff! I left one minor comment. Not a showstopper, as we have the same problem in a couple other manual tests, but seems easy to fix and might save us some headaches down the road 🤷♂️
But yeah re your comment on the issue, I think it's fine to handle these as one-offs rather than adding support to test case recorder
src/test/suite/scroll.test.ts
Outdated
Comment on lines
31
to
35
| mark: { | ||
| type: "decoratedSymbol", | ||
| symbolColor: "default", | ||
| character: "w", | ||
| }, |
There was a problem hiding this comment.
as above, maybe we should just use cursor mark to avoid hat allocation fragility?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #160
Checklist