Disable Cursorless for vscode file dialogs #2749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phillco
reviewed
Jan 25, 2025
phillco
reviewed
Jan 25, 2025
phillco
reviewed
Jan 25, 2025
|
NB: quickly tested on macOS; there, they don't use the operating system pickers for these, they show a custom fuzzy picker UI. I was actually surprised that they don't do this on windows. When this view is shown the window title doesn't change, but we also don't need to change the command ever behavior, so it works out.
|
phillco
approved these changes
Jan 25, 2025
cursorless-bot
pushed a commit
that referenced
this pull request
Jan 25, 2025
File dialogs interfere with the command server keypress. Commands like `"paste to line"` just ends up with a timeout error in the talon log and nothing happens. I have been running with this in my own fork of cursorless Talon for a while to test it out and I'm happy with the result. ## Checklist - [/] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [/] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [/] I have not broken the cheatsheet --------- Co-authored-by: Phil Cohen <phillip@phillip.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File dialogs interfere with the command server keypress. Commands like
"paste to line"just ends up with a timeout error in the talon log and nothing happens.I have been running with this in my own fork of cursorless Talon for a while to test it out and I'm happy with the result.
Checklist