-
-
Notifications
You must be signed in to change notification settings - Fork 88
General cleanup #235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General cleanup #235
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Left some comments which I'll now address myself 😊
new SourceBreakpoint(new Location(uri, new Range(line, 0, line, 0))) | ||
new SourceBreakpoint( | ||
new Location(uri, target.selection.selection.start) | ||
) | ||
); | ||
} | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very clean. Good stuff
target.modifier != null || | ||
target.insideOutsideType != null | ||
); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is beautiful. So much cleaner
Uh oh!
There was an error while loading. Please reload this page.