Skip to content

Switch from black to ruff #2306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Switch from black to ruff #2306

merged 2 commits into from
Apr 26, 2024

Conversation

pokey
Copy link
Member

@pokey pokey commented Apr 25, 2024

See https://docs.astral.sh/ruff/formatter/

Checklist

  • I have run Talon spoken form tests
  • [-] I have added tests
  • [-] I have updated the docs and cheatsheet
  • I have not broken the cheatsheet

@pokey pokey marked this pull request as ready for review April 25, 2024 15:42
@pokey pokey requested a review from AndreasArvidsson as a code owner April 25, 2024 15:42
@pokey pokey requested a review from auscompgeek April 25, 2024 15:42
Copy link
Member

@auscompgeek auscompgeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦀

@pokey pokey enabled auto-merge April 26, 2024 14:28
@pokey pokey added this pull request to the merge queue Apr 26, 2024
Merged via the queue into main with commit 4fa46de Apr 26, 2024
14 checks passed
@pokey pokey deleted the pokey/switch-from-black-to-ruff branch April 26, 2024 15:46
cursorless-bot pushed a commit that referenced this pull request Apr 26, 2024
github-merge-queue bot pushed a commit that referenced this pull request Apr 28, 2024
- Depends on #2306
- Supercedes #2267

This does add a lot of noise, and it can't be enforced in CI because
Talon doesn't publish type stubs (that I know of), so I wonder whether
it's worth it 🤔

## Checklist

- [x] I have run Talon spoken form tests
- [-] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [-] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [x] I have not broken the cheatsheet
cursorless-bot pushed a commit to cursorless-dev/cursorless-talon that referenced this pull request Apr 28, 2024
- Depends on cursorless-dev/cursorless#2306
- Supercedes cursorless-dev/cursorless#2267

This does add a lot of noise, and it can't be enforced in CI because
Talon doesn't publish type stubs (that I know of), so I wonder whether
it's worth it 🤔

## Checklist

- [x] I have run Talon spoken form tests
- [-] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [-] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [x] I have not broken the cheatsheet
cursorless-bot pushed a commit that referenced this pull request Apr 28, 2024
- Depends on #2306
- Supercedes #2267

This does add a lot of noise, and it can't be enforced in CI because
Talon doesn't publish type stubs (that I know of), so I wonder whether
it's worth it 🤔

## Checklist

- [x] I have run Talon spoken form tests
- [-] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [-] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [x] I have not broken the cheatsheet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants