Fix interior scope tests #2218
Merged
Fix interior scope tests #2218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pokey
commented
Feb 1, 2024
There was a problem hiding this comment.
I'm a bit surprised by this one 🤔
There was a problem hiding this comment.
Yeah having an interior on the document is a bit meaningless. Appears that interior does not group together with the other ranges though.
There was a problem hiding this comment.
Oh yeah interesting point. I'm guessing that's because interior is a target, not a range
There was a problem hiding this comment.
Ok I looked at the code. Totally forgot that "inside file" is the file without any leading or trailing whitespace. I updated the test to capture that fact, but wow, I have never used that feature 😅
AndreasArvidsson
approved these changes
Feb 2, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist