Add surrounding pair modifier (#3) #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciejklimek
force-pushed
the
inside_scope
branch
3 times, most recently
from
d23f507
to
bc83546
Compare
maciejklimek
force-pushed
the
inside_scope
branch
from
bc83546
to
80faa99
Compare
pokey
reviewed
Aug 9, 2021
| - anchor: {line: 0, character: 17} | ||
| active: {line: 0, character: 20} | ||
| finalState: | ||
| documentContents: "{const [] = [foo, bar]}" |
There was a problem hiding this comment.
This is the only one I'm not in love with; it really only looks at start of selection, so if end of selection is outside of pair it will still count as containing. Would be more work to get this case working so I'm not sure it's worth the trouble
pokey
approved these changes
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the matching modifier.