Skip to content

Add VscodeFancyRangeHighlighter #1649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 18, 2023
Merged

Add VscodeFancyRangeHighlighter #1649

merged 2 commits into from
Jul 18, 2023

Conversation

pokey
Copy link
Member

@pokey pokey commented Jul 17, 2023 •
edited
Loading

Checklist

This was referenced Jul 17, 2023
Closed
Merged
Merged
@pokey pokey force-pushed the pokey/add-vscodefancyrangehighlighter branch from 8cc5851 to aaf5c7a Compare July 17, 2023 14:16
@pokey pokey changed the base branch from pokey/add-vscodeapi-for-mocking to base/pokey/add-vscodefancyrangehighlighter July 17, 2023 14:16
@pokey pokey force-pushed the pokey/add-vscodefancyrangehighlighter branch from aaf5c7a to 6f9e842 Compare July 17, 2023 14:18
@pokey pokey marked this pull request as ready for review July 17, 2023 14:19
@pokey pokey requested a review from AndreasArvidsson July 17, 2023 14:19
@pokey pokey mentioned this pull request Jul 17, 2023
Merged
9 tasks
pokey
pokey commented Jul 17, 2023
View reviewed changes
...VscodeFancyRangeHighlighter/generateDecorationsForCharacterRange/handleMultipleLines.test.ts
expected: LineDecorations[];
}

const testCases: TestCase[] = [
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test representation is a bit terse, but the hover is really helpful for understanding the shape, and you get the hang of it pretty quickly. Otherwise the tests become a bit annoying to read because every single attribute gets its own line so it's about 10x as many lines

@pokey pokey marked this pull request as draft July 17, 2023 14:49
@pokey pokey removed the request for review from AndreasArvidsson July 17, 2023 14:50
github-merge-queue bot pushed a commit that referenced this pull request Jul 18, 2023
@pokey
Add generalized range utility functions (#1645)
d69c4a9 
- Required by #1649

## Checklist

- [ ] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [ ] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [ ] I have not broken the cheatsheet
github-merge-queue bot pushed a commit that referenced this pull request Jul 18, 2023
@pokey
Add vscodeApi for mocking (#1648)
e96c0c6 
- Required by #1649

## Checklist

- [ ] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [ ] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [ ] I have not broken the cheatsheet
@pokey pokey force-pushed the pokey/add-vscodefancyrangehighlighter branch from 6f9e842 to 258d310 Compare July 18, 2023 11:11
@pokey pokey changed the base branch from base/pokey/add-vscodefancyrangehighlighter to main July 18, 2023 11:12
@pokey pokey marked this pull request as ready for review July 18, 2023 11:12
@pokey pokey enabled auto-merge July 18, 2023 11:12
@pokey pokey added this pull request to the merge queue Jul 18, 2023
Merged via the queue into main with commit cd8b6a1 Jul 18, 2023
@pokey pokey deleted the pokey/add-vscodefancyrangehighlighter branch July 18, 2023 12:28
github-merge-queue bot pushed a commit that referenced this pull request Jul 18, 2023
@pokey @pre-commit-ci-lite
Add the scope visualizer (#1653)
77a3b55 
- Depends on #1651
- Depends on #1652
- Depends on #1649
- Depends on #1644
## Checklist

- [x] Add image to doc page
- [x] File issue to migrate all our vscode references to use new thin
wrapper
- [x] File issue about reworking removal highlight range to return
generalised range, and not using line range for line target content
range
- [x] Investigate cheatsheet performance issue
- [x] Migrate todos from #1523 
- [x] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [x] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [x] I have not broken the cheatsheet
- [x] Compute border colors from background color?

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
cursorless-bot pushed a commit to cursorless-dev/cursorless-talon that referenced this pull request Jul 19, 2023
@pokey @pre-commit-ci-lite @cursorless-bot
Add the scope visualizer (#1653)
da4cb62 
- Depends on cursorless-dev/cursorless#1651
- Depends on cursorless-dev/cursorless#1652
- Depends on cursorless-dev/cursorless#1649
- Depends on cursorless-dev/cursorless#1644
## Checklist

- [x] Add image to doc page
- [x] File issue to migrate all our vscode references to use new thin
wrapper
- [x] File issue about reworking removal highlight range to return
generalised range, and not using line range for line target content
range
- [x] Investigate cheatsheet performance issue
- [x] Migrate todos from #1523 
- [x] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [x] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [x] I have not broken the cheatsheet
- [x] Compute border colors from background color?

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
cursorless-bot pushed a commit that referenced this pull request Jul 19, 2023
@pokey @pre-commit-ci-lite
Add the scope visualizer (#1653)
4af3d41 
- Depends on #1651
- Depends on #1652
- Depends on #1649
- Depends on #1644
## Checklist

- [x] Add image to doc page
- [x] File issue to migrate all our vscode references to use new thin
wrapper
- [x] File issue about reworking removal highlight range to return
generalised range, and not using line range for line target content
range
- [x] Investigate cheatsheet performance issue
- [x] Migrate todos from #1523 
- [x] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [x] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [x] I have not broken the cheatsheet
- [x] Compute border colors from background color?

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreasArvidsson AndreasArvidsson AndreasArvidsson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pokey @AndreasArvidsson