Skip to content

Update Talon side for new destination types #1632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 19 commits into from

Conversation

AndreasArvidsson
Copy link
Member

@AndreasArvidsson AndreasArvidsson commented Jul 13, 2023

Since I had to basically update every capture and action with the new formats I took the liberty of doing some general cleanup and maintenance in this pr.

Ponderings:

  • Should we create a single python file with Cursorless public interface? Today I believe some of them are in actions and some in snippets and so on.
  • It's quite hard to know where the default spoken forms are located. I'm leaning more and more towards just having a single folder with son files that the fine all our spoken forms.

Fixes #1440
Fixes #725
Fixes #803

Checklist

  • Handled migration of csv files
  • Update cheat sheet
  • Update documentation
  • Migrate modifiers to data classes?
  • Figure out how to handle fallback of Cursorless commands when the editor is not in focus in a more standardized way
  • I have added tests
  • I have updated the docs and cheatsheet
  • I have not broken the cheatsheet

@AndreasArvidsson AndreasArvidsson marked this pull request as ready for review July 14, 2023 15:54
@AndreasArvidsson AndreasArvidsson requested a review from pokey as a code owner July 14, 2023 15:54
@AndreasArvidsson
Copy link
Member Author

AndreasArvidsson commented Jul 14, 2023

@pokey I think this is ready for a preliminary review. There are still a few tasks left to do, but I think discussing the current direction could be useful.
I've done some rudimentary testing and everything appears to be working. My plan is to start working on the Talon grammar testing using this branch of Cursorless to get some more manual testing done.

@pokey
Copy link
Member

pokey commented Jul 14, 2023

Nice!

Re testing: you mean you'll base the testing branch off main, but will install this PR locally to drive while you're developing?

@AndreasArvidsson
Copy link
Member Author

Exactly like that

@auscompgeek auscompgeek added the talon Related to cursorless-talon label Jul 15, 2023
@AndreasArvidsson
Copy link
Member Author

Closed in favor of #1637

@AndreasArvidsson AndreasArvidsson deleted the destination-talon branch July 30, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
talon Related to cursorless-talon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rework Talon side to use destinations Destinations as first-class objects Use data classes on talon side in order to get better type hints
3 participants