Skip to content

Enforce undefined on target clone parameters #1627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

pokey
Copy link
Member

@pokey pokey commented Jul 13, 2023

Expands on type checking introduced by #1534 by enforcing optional clone parameters. This change did catch some forgotten parameters

Checklist

  • [-] I have added tests
  • [-] I have updated the docs and cheatsheet
  • [-] I have not broken the cheatsheet

@pokey
Copy link
Member Author

pokey commented Jul 18, 2024

looks like this code actually landed in #1961. No idea why this PR was still open 😅

@pokey pokey closed this Jul 18, 2024
@pokey pokey deleted the pokey/enforce-undefined-on-target-clone-parameters branch July 18, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant