Fix "instance first three chars"
#1520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pokey
commented
Jun 8, 2023
| protected getCloneParameters() { | ||
| return { | ||
| ...this.state, | ||
| isToken: this.isToken, |
There was a problem hiding this comment.
We really gotta figure out a way to make the clone parameters have a stronger type. Forgetting to include custom parameters is something that has hit us multiple times
phillco
approved these changes
Jun 11, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
3 tasks
pokey
pushed a commit
that referenced
this pull request
Jun 17, 2023
## Context #1520 (comment) ## What This adds a generic to `BaseTarget`, which is expected to receive the type of the subclass' parameters. This tries its best to enforce that is the case, and ensures implementations of `getCloneParameters` return that declared type. ## Checklist - [ ] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [ ] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [ ] I have not broken the cheatsheet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was that constructing a character range inadvertently resulted in a target with
isToken = true, because when we clone the anchor target to create the new range target, we forgot to include theisToken = false.Checklist