Skip to content

Support #start-position! and #end-position! predicates #1502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 1, 2023
Merged

Support #start-position! and #end-position! predicates #1502

merged 2 commits into from
Jun 1, 2023

Conversation

pokey
Copy link
Member

@pokey pokey commented May 25, 2023

Checklist

@pokey pokey force-pushed the pokey/add-mutable-query-capture-interface branch from a2092d8 to fc584ff Compare May 26, 2023 14:20
@pokey pokey force-pushed the pokey/support-start-and-end-predicates branch from b75a7ac to 57fe097 Compare May 26, 2023 14:20
@pokey pokey force-pushed the pokey/add-mutable-query-capture-interface branch from ab000fa to 76de478 Compare May 28, 2023 13:46
@pokey pokey force-pushed the pokey/support-start-and-end-predicates branch 2 times, most recently from 0749832 to f51e100 Compare May 28, 2023 13:51
@pokey pokey requested a review from AndreasArvidsson May 28, 2023 13:53
@pokey pokey force-pushed the pokey/support-start-and-end-predicates branch from f51e100 to f21f280 Compare May 28, 2023 14:01
@pokey pokey force-pushed the pokey/add-mutable-query-capture-interface branch from 7af7150 to 618cd42 Compare May 28, 2023 14:40
@pokey pokey force-pushed the pokey/support-start-and-end-predicates branch from f21f280 to 084efe7 Compare May 28, 2023 14:40
@pokey pokey force-pushed the pokey/add-mutable-query-capture-interface branch from 618cd42 to 8e32594 Compare May 28, 2023 14:44
@pokey pokey force-pushed the pokey/support-start-and-end-predicates branch from 084efe7 to 6f793c9 Compare May 28, 2023 14:44
@pokey
Copy link
Member Author

pokey commented May 30, 2023 •
edited
Loading

I wonder if we should be a bit more verbose with these operator names. Maybe position-at-start?

Here's a few other options, courtesy of Chatgpt:

  1. anchor-start and anchor-end
  2. position-at-start and position-at-end
  3. zero-width-start and zero-width-end
  4. pinpoint-start and pinpoint-end
  5. origin-point and terminus-point
  6. mark-start and mark-end
  7. snap-start and snap-end

Base automatically changed from pokey/add-mutable-query-capture-interface to main May 30, 2023 13:27
@pokey pokey force-pushed the pokey/support-start-and-end-predicates branch from 6f793c9 to f83341b Compare May 30, 2023 14:53
@pokey
Copy link
Member Author

pokey commented May 30, 2023

decided on start-position and end-position

@pokey pokey changed the title Support #start! and #end! predicates Support #start-position! and #end-position! predicates May 31, 2023
@pokey pokey marked this pull request as ready for review May 31, 2023 19:45
@pokey pokey enabled auto-merge May 31, 2023 19:46
@pokey pokey added this pull request to the merge queue Jun 1, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 1, 2023
@pokey pokey added this pull request to the merge queue Jun 1, 2023
Merged via the queue into main with commit 2ab1e54 Jun 1, 2023
@pokey pokey deleted the pokey/support-start-and-end-predicates branch June 1, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreasArvidsson AndreasArvidsson AndreasArvidsson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support #end! and #start! predicates
2 participants
@pokey @AndreasArvidsson