Add integration test setup; check for legacy/new scope duplicates #1428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pokey
force-pushed
the
bases/pokey/add-support-for-domain-leading-trailing-interior
branch
from
f083bea to
aab6502
Compare
pokey
force-pushed
the
pokey/add-integration-test-setup-check-for-legacynew-scope-duplicates
branch
2 times, most recently
from
8bc2544 to
b0e6e8e
Compare
auscompgeek
reviewed
Apr 16, 2023
| @@ -68,5 +69,7 @@ export function createCursorlessEngine( | |||
| hatTokenMap, | |||
| snippets, | |||
| injectIde, | |||
| runIntegrationTests: () => | |||
| runIntegrationTests(treeSitter, languageDefinitions), | |||
There was a problem hiding this comment.
If we instead expose treeSitter and languageDefinitions, then we could avoid runIntegrationTests ending up in the prod bundle, right?
There was a problem hiding this comment.
No I don't think that would help. The issue is that the test needs to be defined inside cursorless engine; see PR description for more detail. Also notice that treeSitter actually comes from the caller, so exposing it wouldn't actually do anything
We'd need to expose everything imported in the file that defines the integration tests
But maybe I've misunderstood your proposal?
pokey
force-pushed
the
pokey/add-integration-test-setup-check-for-legacynew-scope-duplicates
branch
from
b0e6e8e to
dfe7e46
Compare
pokey
force-pushed
the
bases/pokey/add-support-for-domain-leading-trailing-interior
branch
from
c0aeedf to
631aa40
Compare
pokey
force-pushed
the
pokey/add-integration-test-setup-check-for-legacynew-scope-duplicates
branch
2 times, most recently
from
7b8c289 to
a5b756c
Compare
pokey
force-pushed
the
pokey/add-integration-test-setup-check-for-legacynew-scope-duplicates
branch
from
a5b756c to
c4191dd
Compare
pokey
changed the base branch from
bases/pokey/add-support-for-domain-leading-trailing-interior
to
main
…egacynew-scope-duplicates
AndreasArvidsson
approved these changes
Jun 17, 2023
AndreasArvidsson
deleted the
pokey/add-integration-test-setup-check-for-legacynew-scope-duplicates
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test to ensure that we don't try to define the same scope type both using our legacy node matchers and the new query scope handlers
I have mixed feelings about the way I made this work, but I wasn't sure how else to do it. The test needs to be defined in the engine, because otherwise we'd need to expose lots of stuff to cursorless-vscode-e2e, but it needs a full tree-sitter instance, so can't be run as a unit test. This file is the compromise I came up with 🤷♂️. We should maybe revise once we have tree-sitter integrated with this repo
I don't like that this code gets rolled up into our production bundle, but probably ok for this one-off. If we find this file growing, we should revisit
It's also possible that once we get rid of our
idesingleton, we can relax the restriction that our test harness doesn't import fromcursorless-engine. That would enable us to just import what we need from the engine directly in the test harness to run this test 🤔Checklist