Skip to content

Support "name" / "key" / "condition" for switch statements #1150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

pokey
Copy link
Member

@pokey pokey commented Nov 18, 2022

Checklist

  • Typescript
  • C++
  • C#
  • Java
  • Python
  • Rust
  • I have added tests
  • I have updated the docs and cheatsheet
  • I have not broken the cheatsheet

Co-authored-by: Michael Doronin warrior2031@mail.ru

@pokey pokey force-pushed the pokey/add-branch-scope-type branch from 78fa594 to d6fe259 Compare November 18, 2022 17:34
@pokey pokey force-pushed the pokey/add-condition-for-case-statements branch 2 times, most recently from 71aa706 to a5e97fa Compare November 18, 2022 18:15
@pokey pokey force-pushed the pokey/add-branch-scope-type branch from a3e4576 to 90619bc Compare November 18, 2022 18:23
@pokey pokey force-pushed the pokey/add-condition-for-case-statements branch 3 times, most recently from c8619ea to 9e7988a Compare November 18, 2022 18:44
@pokey pokey force-pushed the pokey/add-branch-scope-type branch from 7350720 to adf7c5e Compare November 18, 2022 18:46
@pokey pokey force-pushed the pokey/add-condition-for-case-statements branch from 9e7988a to 80a6258 Compare November 18, 2022 18:46
@pokey pokey force-pushed the pokey/add-branch-scope-type branch from adf7c5e to 7ba66c5 Compare November 18, 2022 18:55
@pokey pokey force-pushed the pokey/add-condition-for-case-statements branch from 80a6258 to 52d05c7 Compare November 18, 2022 18:55
@pokey pokey changed the title Add condition for case statements Support "name" / "key" / "condition" for switch statements Dec 14, 2022
@pokey pokey linked an issue Dec 14, 2022 that may be closed by this pull request
6 tasks
@pokey
Copy link
Member Author

pokey commented Dec 15, 2022

Closing until someone has bandwidth to finish this PR

@pokey pokey closed this Dec 15, 2022
@pokey
Copy link
Member Author

pokey commented Dec 15, 2022

After discussion in meet-up:

Just kidding; let's get this thing in for the languages that exist here. more useful to at least have it functional in some places

@pokey pokey reopened this Dec 15, 2022
@pokey pokey self-assigned this Dec 15, 2022
@pokey pokey changed the base branch from pokey/add-branch-scope-type to main January 3, 2023 12:52
@pokey pokey force-pushed the pokey/add-condition-for-case-statements branch from 52d05c7 to 323a4aa Compare January 3, 2023 12:52
@pokey
Copy link
Member Author

pokey commented Jan 3, 2023

Closing because this is kinda broken, and will be easier to implement using new patterns (#629)

@pokey pokey closed this Jan 3, 2023
@pokey pokey deleted the pokey/add-condition-for-case-statements branch February 16, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant