Repository navigation
Conversation
|
@deanrie is attempting to deploy a commit to the Anysphere Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parse.tsturns a relativelogoin a plugin manifest intohttps://raw.githubusercontent.com/<owner>/<repo>/HEAD/<path>, and absolute logos are kept as submitted, so a plugin's logo can live on any host. The detail page renders it withnext/imagethrough the optimizer, which rejects hosts missing fromimages.remotePatternsand fails the whole page.raw.githubusercontent.comis not in that list, so every submission that followscursor/plugin-template(relativeassets/logo.svg) 500s its own plugin page.AGENTS.mdcurrently documents nulling those logos in the database as the workaround.This marks the
ImageinPluginLogoasunoptimized, which bypasses the allowlist and renders the URL directly.PluginCardandPluginLeaderboardalready render the same URLs as plain<img>viaAvatarImage, so the detail page now behaves like the rest of the site. The logo is at most 40px, so skipping optimization costs nothing noticeable. TheAGENTS.mdnote is updated to match; nulled rows in the database can be restored by a rescan.Adding
raw.githubusercontent.comtoremotePatternsalone would not be enough, since absolute logo URLs from manifests point at arbitrary hosts.Verification
bun x biome cion the file andbun run typecheckinapps/cursorpass (same commands asci.yml).