Skip to content

fix(plugins): render plugin logos unoptimized so any manifest logo host works - #444

Open
deanrie wants to merge 1 commit into
cursor:mainfrom
deanrie:fix/plugin-logo-remote-pattern
Open

deanrie wants to merge 1 commit into
cursor:mainfrom
deanrie:fix/plugin-logo-remote-pattern

Conversation

@deanrie

@deanrie deanrie commented Oct 8, 2026

Copy link
Copy Markdown

Summary

parse.ts turns a relative logo in a plugin manifest into https://raw.githubusercontent.com/<owner>/<repo>/HEAD/<path>, and absolute logos are kept as submitted, so a plugin's logo can live on any host. The detail page renders it with next/image through the optimizer, which rejects hosts missing from images.remotePatterns and fails the whole page. raw.githubusercontent.com is not in that list, so every submission that follows cursor/plugin-template (relative assets/logo.svg) 500s its own plugin page. AGENTS.md currently documents nulling those logos in the database as the workaround.

This marks the Image in PluginLogo as unoptimized, which bypasses the allowlist and renders the URL directly. PluginCard and PluginLeaderboard already render the same URLs as plain <img> via AvatarImage, so the detail page now behaves like the rest of the site. The logo is at most 40px, so skipping optimization costs nothing noticeable. The AGENTS.md note is updated to match; nulled rows in the database can be restored by a rescan.

Adding raw.githubusercontent.com to remotePatterns alone would not be enough, since absolute logo URLs from manifests point at arbitrary hosts.

Verification

  • bun x biome ci on the file and bun run typecheck in apps/cursor pass (same commands as ci.yml).

@vercel

vercel Bot commented Oct 8, 2026

Copy link
Copy Markdown

@deanrie is attempting to deploy a commit to the Anysphere Team on Vercel.

A member of the Team first needs to authorize it.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant