feat: validate skill in CI with agnix#7
Conversation
|
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthroughAdds a GitHub Actions workflow to validate AI skill configs with agnix, updates SKILL.md front matter (name, description, license, metadata.version), and applies cosmetic formatting changes to testing documentation. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/validate-skill.yml (1)
1-17: Workflow structure looks good overall.The workflow correctly triggers on pushes and pull requests to
main, uses a recent checkout action version, and has a clear job structure.Consider these improvements:
- Pin
agent-sh/agnixto a specific commit SHA for supply-chain security, or use a more stable version tag if available (currently at v0, which is pre-release).- Add
timeout-minutesto the job to prevent runaway jobs.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/validate-skill.yml around lines 1 - 17, Update the Agnix job to pin the action reference and add a job timeout: replace the uses reference "agent-sh/agnix@v0" in the agnix job step with a specific commit SHA or stable version tag (e.g., agent-sh/agnix@<commit-sha-or-tag>) to improve supply-chain security, and add a timeout-minutes property under the agnix job definition (e.g., timeout-minutes: <reasonable-minute-limit>) to prevent runaway runs.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/workflows/validate-skill.yml:
- Around line 1-17: Update the Agnix job to pin the action reference and add a
job timeout: replace the uses reference "agent-sh/agnix@v0" in the agnix job
step with a specific commit SHA or stable version tag (e.g.,
agent-sh/agnix@<commit-sha-or-tag>) to improve supply-chain security, and add a
timeout-minutes property under the agnix job definition (e.g., timeout-minutes:
<reasonable-minute-limit>) to prevent runaway runs.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 7a708444-d1c7-4e2d-81f4-32198c6f846f
📒 Files selected for processing (3)
.github/workflows/validate-skill.ymlSKILL.mdtesting-patterns/forms-validation.md
Summary
Adds agnix to validate our SKILL in CI to avoid breaking it with future Pull Requests
Summary by CodeRabbit
Documentation
Chores