Skip to content

feat: validate skill in CI with agnix#7

Merged
waltergalvao merged 2 commits intomainfrom
feat/ci-skill-validation
Mar 13, 2026
Merged

feat: validate skill in CI with agnix#7
waltergalvao merged 2 commits intomainfrom
feat/ci-skill-validation

Conversation

@waltergalvao
Copy link
Copy Markdown
Contributor

@waltergalvao waltergalvao commented Mar 13, 2026

Summary

Adds agnix to validate our SKILL in CI to avoid breaking it with future Pull Requests

Summary by CodeRabbit

  • Documentation

    • Updated skill metadata (name, description), added license and version details.
    • Improved test/docs formatting for clearer examples and readability.
  • Chores

    • Added an automated validation workflow to run configuration checks on pushes and pull requests.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 13, 2026

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

Adds a GitHub Actions workflow to validate AI skill configs with agnix, updates SKILL.md front matter (name, description, license, metadata.version), and applies cosmetic formatting changes to testing documentation.

Changes

Cohort / File(s) Summary
CI/CD Workflow
​.github/workflows/validate-skill.yml
New GitHub Actions workflow that triggers on pushes and PRs to main and runs the agnix validator (agent-sh/agnix@12a1917d).
Skill Metadata
SKILL.md
Front matter updates: renamed skill to playwright-best-practices-skill, refined description, added license: MIT, and added metadata.version: "1.1" (author retained).
Testing Documentation
testing-patterns/forms-validation.md
Cosmetic formatting changes in code examples (trailing commas, reflowed multi-line objects, assertion line breaks); no semantic or behavioral changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

🐇 I hopped a workflow into the night,
Agnix checked configs with gentle light.
SKILL.md dressed in version and name,
Docs got tidy — the same lovely game.
🥕✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: adding agnix validation in CI, which directly corresponds to the new workflow file and SKILL.md updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/ci-skill-validation
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.github/workflows/validate-skill.yml (1)

1-17: Workflow structure looks good overall.

The workflow correctly triggers on pushes and pull requests to main, uses a recent checkout action version, and has a clear job structure.

Consider these improvements:

  1. Pin agent-sh/agnix to a specific commit SHA for supply-chain security, or use a more stable version tag if available (currently at v0, which is pre-release).
  2. Add timeout-minutes to the job to prevent runaway jobs.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/validate-skill.yml around lines 1 - 17, Update the Agnix
job to pin the action reference and add a job timeout: replace the uses
reference "agent-sh/agnix@v0" in the agnix job step with a specific commit SHA
or stable version tag (e.g., agent-sh/agnix@<commit-sha-or-tag>) to improve
supply-chain security, and add a timeout-minutes property under the agnix job
definition (e.g., timeout-minutes: <reasonable-minute-limit>) to prevent runaway
runs.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In @.github/workflows/validate-skill.yml:
- Around line 1-17: Update the Agnix job to pin the action reference and add a
job timeout: replace the uses reference "agent-sh/agnix@v0" in the agnix job
step with a specific commit SHA or stable version tag (e.g.,
agent-sh/agnix@<commit-sha-or-tag>) to improve supply-chain security, and add a
timeout-minutes property under the agnix job definition (e.g., timeout-minutes:
<reasonable-minute-limit>) to prevent runaway runs.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7a708444-d1c7-4e2d-81f4-32198c6f846f

📥 Commits

Reviewing files that changed from the base of the PR and between 4839a82 and 4e40465.

📒 Files selected for processing (3)
  • .github/workflows/validate-skill.yml
  • SKILL.md
  • testing-patterns/forms-validation.md

@waltergalvao waltergalvao merged commit 865d1fe into main Mar 13, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant