Skip to content

Update file structure to conform with new skills behavior#10

Open
WikiRik wants to merge 1 commit into
currents-dev:mainfrom
octalign:upstream-pr
Open

Update file structure to conform with new skills behavior#10
WikiRik wants to merge 1 commit into
currents-dev:mainfrom
octalign:upstream-pr

Conversation

@WikiRik

@WikiRik WikiRik commented Jul 8, 2026

Copy link
Copy Markdown

Fixes #8 and #9 without relying on updates of https://github.com/vercel-labs/skills

Feel free to comment if the updated version number is preferred or not, I can always update.

Summary by CodeRabbit

  • Chores
    • Updated the skill metadata version from 1.1 to 2.0.

@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ba75de94-2865-4f13-b6af-46a649111a9d

📥 Commits

Reviewing files that changed from the base of the PR and between ef329e7 and a79cf1d.

📒 Files selected for processing (59)
  • playwright-best-practices/SKILL.md
  • playwright-best-practices/advanced/authentication-flows.md
  • playwright-best-practices/advanced/authentication.md
  • playwright-best-practices/advanced/clock-mocking.md
  • playwright-best-practices/advanced/mobile-testing.md
  • playwright-best-practices/advanced/multi-context.md
  • playwright-best-practices/advanced/multi-user.md
  • playwright-best-practices/advanced/network-advanced.md
  • playwright-best-practices/advanced/third-party.md
  • playwright-best-practices/architecture/pom-vs-fixtures.md
  • playwright-best-practices/architecture/test-architecture.md
  • playwright-best-practices/architecture/when-to-mock.md
  • playwright-best-practices/browser-apis/browser-apis.md
  • playwright-best-practices/browser-apis/iframes.md
  • playwright-best-practices/browser-apis/service-workers.md
  • playwright-best-practices/browser-apis/websockets.md
  • playwright-best-practices/core/annotations.md
  • playwright-best-practices/core/assertions-waiting.md
  • playwright-best-practices/core/configuration.md
  • playwright-best-practices/core/fixtures-hooks.md
  • playwright-best-practices/core/global-setup.md
  • playwright-best-practices/core/locators.md
  • playwright-best-practices/core/page-object-model.md
  • playwright-best-practices/core/projects-dependencies.md
  • playwright-best-practices/core/test-data.md
  • playwright-best-practices/core/test-suite-structure.md
  • playwright-best-practices/core/test-tags.md
  • playwright-best-practices/debugging/console-errors.md
  • playwright-best-practices/debugging/debugging.md
  • playwright-best-practices/debugging/error-testing.md
  • playwright-best-practices/debugging/flaky-tests.md
  • playwright-best-practices/frameworks/angular.md
  • playwright-best-practices/frameworks/nextjs.md
  • playwright-best-practices/frameworks/react.md
  • playwright-best-practices/frameworks/vue.md
  • playwright-best-practices/infrastructure-ci-cd/ci-cd.md
  • playwright-best-practices/infrastructure-ci-cd/docker.md
  • playwright-best-practices/infrastructure-ci-cd/github-actions.md
  • playwright-best-practices/infrastructure-ci-cd/gitlab.md
  • playwright-best-practices/infrastructure-ci-cd/other-providers.md
  • playwright-best-practices/infrastructure-ci-cd/parallel-sharding.md
  • playwright-best-practices/infrastructure-ci-cd/performance.md
  • playwright-best-practices/infrastructure-ci-cd/reporting.md
  • playwright-best-practices/infrastructure-ci-cd/test-coverage.md
  • playwright-best-practices/testing-patterns/accessibility.md
  • playwright-best-practices/testing-patterns/api-testing.md
  • playwright-best-practices/testing-patterns/browser-extensions.md
  • playwright-best-practices/testing-patterns/canvas-webgl.md
  • playwright-best-practices/testing-patterns/component-testing.md
  • playwright-best-practices/testing-patterns/drag-drop.md
  • playwright-best-practices/testing-patterns/electron.md
  • playwright-best-practices/testing-patterns/file-operations.md
  • playwright-best-practices/testing-patterns/file-upload-download.md
  • playwright-best-practices/testing-patterns/forms-validation.md
  • playwright-best-practices/testing-patterns/graphql-testing.md
  • playwright-best-practices/testing-patterns/i18n.md
  • playwright-best-practices/testing-patterns/performance-testing.md
  • playwright-best-practices/testing-patterns/security-testing.md
  • playwright-best-practices/testing-patterns/visual-regression.md

📝 Walkthrough

Walkthrough

Updated the version field in the metadata block of playwright-best-practices/SKILL.md from "1.1" to "2.0".

Changes

Version Metadata Update

Layer / File(s) Summary
Update version metadata
playwright-best-practices/SKILL.md
The metadata.version value is changed from "1.1" to "2.0".

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title mentions file structure changes, but the only documented change is a version bump in SKILL.md. Rename the PR to reflect the actual change, such as updating SKILL.md metadata or the skill compatibility version.
Linked Issues check ⚠️ Warning The PR only bumps SKILL.md version metadata and does not show the structure change needed to stop npx skills update removing the skill [#8]. Implement the structure or manifest changes that preserve the skill during npx skills update, and verify the update flow keeps it installed.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Out of Scope Changes check ✅ Passed No clearly unrelated files or features were added; the change is limited to SKILL.md metadata.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@WikiRik

WikiRik commented Jul 17, 2026

Copy link
Copy Markdown
Author

I'm keeping this open so that the .github/.agnix.toml etc don't get included in the skill when installing, but the skill works again without this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

npx skills update the skill

1 participant