feat: add browser logs #22

vCaisim · 2023-03-27T14:29:51Z

Changes:

added run context to the meta field (Pack all the information and prepare for upload #4)
packed the information at a test level (Pack all the information and prepare for upload #4)
added browser console messages (Explore how can we collect console messages #5)
described the plugin in README.md (Create documentation and walk potential developer through the setup and usage #9)
added a field for metadata (Have a field for metadata in the events file #18)
moved the types from the UI, and merged them with existing ones
renamed the cypress steps to cypress events in the UI
moved UI from Nextjs to Reactjs + Vite + Typescript (Make UI client-side only (no server required) #24)
added callback function (Explore how can we collect console messages #5)

agoldis · 2023-03-28T06:59:53Z

@vCaisim is it ready? A short demo would be great. Also, please update the status of the tasks in https://github.com/orgs/currents-dev/projects/4

agoldis · 2023-03-29T08:03:47Z

@vCaisim is it ready for review? if yes, please move the associated tasks in https://github.com/currents-dev/cypress-debugger/projects?query=is%3Aopen

vCaisim · 2023-03-29T08:16:35Z

@vCaisim is it ready for review? if yes, please move the associated tasks in https://github.com/currents-dev/cypress-debugger/projects?query=is%3Aopen

Let me make some small changes, and update the UI a bit. I will ask for review later

vCaisim · 2023-03-29T14:35:56Z

console messages UI update:

packages/plugin/src/browserLogs.ts

agoldis · 2023-03-30T08:08:04Z

https://www.loom.com/share/f06838f546cd4c1f99c1e6925014f26f

vCaisim · 2023-03-30T08:18:02Z

https://www.loom.com/share/f06838f546cd4c1f99c1e6925014f26f

Thanks for the feedback. I will analyze how puppeteer uses CDP.

agoldis

@vSaicim that's great, especially for a POC, I think we can publish it soon.

Please see inline comments, but also I am seeing the use of any across the board. What do you think of removing as many any as possible?

packages/support/src/events/enhancer.ts

packages/support/src/cy/testHandlers.ts

agoldis · 2023-04-03T08:48:02Z

packages/plugin/src/browserLogs.ts

+    return Number(existing.split("=")[1]);
+  }
+
+  // running cypress with ELECTRON_EXTRA_LAUNCH_ARGS="--remote-debugging-port=9222" do not set the args


@vCaisim what do you mean here? Please elaborate

The debugging port is retrieved from the browser launch args. For electron, the args is an empty object

ok, please provide an example of how the debugging port is retrieved for chrome and electron - it help to maintain the project\

added details here: https://github.com/currents-dev/cypress-debugger/blob/feat/console-messages/packages/plugin/src/browserLogs.ts#L24

agoldis

From the previous review: please provide an example of how the debugging port is retrieved for chrome and electron - it help to maintain the project

packages/plugin/src/fs.ts

packages/support/package.json

feat: add browser logs

994731b

vCaisim requested a review from agoldis March 27, 2023 14:29

vCaisim added 4 commits March 28, 2023 16:41

chore: move from next to react + vite + typescript

9fdeac5

feat: add callback option

1951fcf

feat: add logs from the Console api

ca38391

fix: use useSearchParams to get the payload query param

8061f7c

vCaisim added 4 commits March 29, 2023 12:29

fix: clear the payload query param when the payload is removed

8cbb7e7

fix: reset the state when the payload param is removed

fd69bf4

feat: update the UI for console messages

9aeefe9

fix: get the correct values from the Console browser api

b039b88

vCaisim marked this pull request as ready for review March 29, 2023 14:37

agoldis reviewed Mar 30, 2023

View reviewed changes

packages/plugin/src/browserLogs.ts Outdated Show resolved Hide resolved

vCaisim added 3 commits March 30, 2023 17:10

chore: do not use logs from the deprecated Console domain

de93226

chore: limit the connection retries to the Chrome Debugging Protocol

dacd451

fix: handle electron

e512b06

agoldis reviewed Apr 3, 2023

View reviewed changes

packages/support/src/events/enhancer.ts Outdated Show resolved Hide resolved

packages/support/src/cy/testHandlers.ts Outdated Show resolved Hide resolved

agoldis reviewed Apr 3, 2023

View reviewed changes

vCaisim added 4 commits April 3, 2023 13:12

chore: small ui update

599a295

chore: mini refactor

601a8ac

chore: reconnect to cdp before each spec

540573d

chore: remove docs and ui packages

c062d23

agoldis requested changes Apr 5, 2023

View reviewed changes

packages/plugin/src/fs.ts Show resolved Hide resolved

packages/plugin/src/fs.ts Show resolved Hide resolved

packages/plugin/src/fs.ts Show resolved Hide resolved

agoldis reviewed Apr 5, 2023

View reviewed changes

packages/support/package.json Outdated Show resolved Hide resolved

chore: remove logs and comments

428f8b0

vCaisim added 6 commits April 5, 2023 12:42

fix: move the chrome-remote-interface dependences to the plugin package

a861f77

chore: import the types from cypress-debugger

a728799

fix: comments

8e10453

feat: add PluginOptions type

5eb5578

update README

67c8b7e

fix: return rdp port depending on browser

d3d1e05

agoldis merged commit 77820c1 into main Apr 6, 2023

agoldis deleted the feat/console-messages branch April 6, 2023 08:35

This was referenced Apr 6, 2023

Explore how can we collect console messages #5

Closed

Make UI client-side only (no server required) #24

Closed

Have a field for metadata in the events file #18

Closed

Pack all the information and prepare for upload #4

Closed

feat: add browser logs #22

feat: add browser logs #22

Uh oh!

Conversation

vCaisim commented Mar 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

agoldis commented Mar 28, 2023

Uh oh!

agoldis commented Mar 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vCaisim commented Mar 29, 2023

Uh oh!

vCaisim commented Mar 29, 2023

Uh oh!

Uh oh!

agoldis commented Mar 30, 2023

Uh oh!

vCaisim commented Mar 30, 2023

Uh oh!

agoldis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

agoldis Apr 3, 2023

Choose a reason for hiding this comment

Uh oh!

vCaisim Apr 3, 2023

Choose a reason for hiding this comment

Uh oh!

agoldis Apr 3, 2023

Choose a reason for hiding this comment

Uh oh!

vCaisim Apr 5, 2023

Choose a reason for hiding this comment

Uh oh!

agoldis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vCaisim commented Mar 27, 2023 •

edited

Loading

agoldis commented Mar 29, 2023 •

edited

Loading