Skip to content

Commit f439bb3

Browse files
jmillikin-stripemattklein123
authored andcommitted
Add api_go_proto_library targets for HTTP connection manager protos. (envoyproxy#584)
These are required to generate xDS responses from a Go binary. If they don't exist, implementations are required to vendor the data-plane-api with this change applied. Signed-off-by: John Millikin <jmillikin@stripe.com>
1 parent c7baab2 commit f439bb3

File tree

2 files changed

+26
-2
lines changed
  • envoy/config/filter
    • accesslog/v2
    • network/http_connection_manager/v2

2 files changed

+26
-2
lines changed

envoy/config/filter/accesslog/v2/BUILD

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
load("//bazel:api_build_system.bzl", "api_proto_library")
1+
load("//bazel:api_build_system.bzl", "api_proto_library", "api_go_proto_library")
22

33
licenses(["notice"]) # Apache 2
44

@@ -18,3 +18,14 @@ api_proto_library(
1818
"//envoy/type:percent",
1919
],
2020
)
21+
22+
api_go_proto_library(
23+
name = "accesslog",
24+
proto = ":accesslog",
25+
deps = [
26+
"//envoy/api/v2/core:address_go_proto",
27+
"//envoy/api/v2/core:base_go_proto",
28+
"//envoy/api/v2/core:grpc_service_go_proto",
29+
"//envoy/type:percent_go_proto",
30+
],
31+
)

envoy/config/filter/network/http_connection_manager/v2/BUILD

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
load("//bazel:api_build_system.bzl", "api_proto_library")
1+
load("//bazel:api_build_system.bzl", "api_proto_library", "api_go_proto_library")
22

33
licenses(["notice"]) # Apache 2
44

@@ -14,3 +14,16 @@ api_proto_library(
1414
"//envoy/type:percent",
1515
],
1616
)
17+
18+
api_go_proto_library(
19+
name = "http_connection_manager",
20+
proto = ":http_connection_manager",
21+
deps = [
22+
"//envoy/api/v2:rds_go_grpc",
23+
"//envoy/api/v2/core:base_go_proto",
24+
"//envoy/api/v2/core:config_source_go_proto",
25+
"//envoy/api/v2/core:protocol_go_proto",
26+
"//envoy/config/filter/accesslog/v2:accesslog_go_proto",
27+
"//envoy/type:percent_go_proto",
28+
],
29+
)

0 commit comments

Comments
 (0)