feat: add NAMESPACE config #534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for sanitize svg/mathML child innerHTML resolve cure53#533
Owner
|
This looks very sexy, let me review this today, thank you :) |
Contributor
Author
|
Line 708 in 0bc9786 this change cause error in firefox |
Owner
|
Yeah, I am fine with this side effect for now. |
Owner
|
Oof, the tests are green and now even MSIE is happy. Somewhat :D |
Owner
|
Thank you for this PR! Much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for sanitize svg/mathML child innerHTML
resolve #533
Background & Context
mXSS protection added in #495 removed the ability to sanitize svg/mathML fragment.
Need a option to re-enable them.
Tasks
lint error before i made the change: