Skip to content

Harden protection against mutation XSS caused by namespace switching #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cure53 merged 19 commits into from
Dec 17, 2020
Merged

Harden protection against mutation XSS caused by namespace switching #495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
43b0784
Get rid of insertAdjacentHTML to avoid reparsing
securitum-mb Dec 15, 2020
b30d7ec
Delete latest mXSS and namespace confusion fixes
securitum-mb Dec 15, 2020
178b43e
Add initial version of namespace checker
securitum-mb Dec 16, 2020
1444e7e
Delete elements that are not truly SVG
securitum-mb Dec 16, 2020
963945e
Tests assumed that noscript contents should be deleted. Added it to F…
securitum-mb Dec 16, 2020
4a93eac
Restore the original namespace confusion check as it also killed SAFE…
securitum-mb Dec 16, 2020
1a7ef88
Fix test 35 -<line> is only allowed in SVG
securitum-mb Dec 16, 2020
e9fbca6
Fix mXSS test; because of the new namespace checks, textarea should n…
securitum-mb Dec 16, 2020
d2eba54
Fix a bunch of mXSS tests
securitum-mb Dec 16, 2020
8179daf
Experiment with the element removal behavior
securitum-mb Dec 16, 2020
bce6bad
Fix another two mXSS tests
securitum-mb Dec 16, 2020
4ab4ff8
Change svgFilters test so that it also requires svg in allowed tags
securitum-mb Dec 16, 2020
8110d44
Harden node removal against DOM clobbering
securitum-mb Dec 16, 2020
ccc2d31
Add a bunch of tests to check namespace enforcement
securitum-mb Dec 16, 2020
0d42de0
Experiment with anticlobber approach
securitum-mb Dec 16, 2020
6b2b871
Fix a terrible mistake in anti-clobber
securitum-mb Dec 17, 2020
21baa58
Another fix in anti-clobber: getChildNodes -> childNodes
securitum-mb Dec 17, 2020
e8c8e89
Move anti-clobber to purify.js
securitum-mb Dec 17, 2020
808cab3
Merge branch 'main' of https://github.com/cure53/DOMPurify
securitum-mb Dec 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
159 changes: 143 additions & 16 deletions dist/purify.cjs.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/purify.cjs.js.map
View file
Open in desktop

Large diffs are not rendered by default.

Loading