Merged
Conversation
aamaredia
commented
Jan 3, 2024
aamaredia
commented
- Errors are returned as a dictionary in the response. The code was passing that along as a string instead of deserializing it to gather the actual failure reason. This would result in exceptions throwing KeyError instead of the actual exception class
- Errors are returned as a dictionary in the response. The code was passing that along as a string instead of deserializing it to gather the actual failure reason. This would result in exceptions throwing KeyError instead of the actual exception class
aamaredia
force-pushed
the
alim/fix-error-handling
branch
from
5b04620 to
138e5c0
Compare
lukediliberto
approved these changes
Jan 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.