-
-
Notifications
You must be signed in to change notification settings - Fork 855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Static link CUDA Runtime #7954
Static link CUDA Runtime #7954
Conversation
/test mini |
33e5a4e
to
385fce3
Compare
/test mini |
Yes it should be a compile time error. LGTM. |
if driver._is_cuda_python(): | ||
version = runtime.runtimeGetVersion() | ||
else: | ||
version = _cuda_hip_version | ||
if ( | ||
not _use_ptx and version >= 11010 | ||
not _use_ptx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI. I think this change is OK. For a more robust treatment for _get_arch()
, I suggest to take a look at this helper function that I added recently. We don't have to do it in this PR or even in v13, since right now we almost always generate SASS which is problem free. But it is possible that the nvcc/nvrtc version is newer than the driver version, and the generated PTX would not be loadable. (I hit this when updating the PTX tests in test_raw.py
, which prompted me to write that helper 🙂)
/test mini |
Would you have a look at cuda-python test failure? |
CUDA Python's getLocalRuntimeVersion does not support CUDA 11.x or Windows
/test mini |
Do we also need to include |
Thanks, that's right! Fixed. /test mini |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can take a final look later today. Reminder to add a CI test: #7954 (comment)
/test mini |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work, LGTM except for one question: I see the version check for JIT was reverted (7a4a4bb), is there any particular reason? I would think checking the header version is safer, instead of using libcuda.so as a proxy. But this is not a big showstopper, we can follow-up later.
See also my above reminder.
Thanks for the reminder! Added. |
The check has been rewritten using |
b55e965
to
aecccf6
Compare
I noticed that we can't test this PR like other modules, because |
This is new to me, thanks for sharing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, merge?
Another way to test it (but only on Linux) is to do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This is a part of #7620.
cupy.cuda.profiler.initialize()
function, which was removed in CUDA 12 and marked deprecated since CuPy v12 (CUDA 12: Deprecate (or remove)cudaProfilerInitialize
#7332). Code search yields no use-case for this function.