Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cupyx.scipy.signal: add CZT and ZoomFFT #7543

Merged
merged 4 commits into from
Jun 6, 2023
Merged

cupyx.scipy.signal: add CZT and ZoomFFT #7543

merged 4 commits into from
Jun 6, 2023

Conversation

ev-br
Copy link
Contributor

@ev-br ev-br commented May 9, 2023 •
edited
Loading

Adapt code and its tests from scipy.

Heavy lifting is all done in cupyx.fft, so the rest is kept in pure python.

cross-ref gh-7403

  • czt
  • zoom_fft
  • CZT
  • ZoomFFT
  • czt_points

@andfoy andfoy mentioned this pull request May 9, 2023
Open
@asi1024 asi1024 added cat:feature New features/APIs prio:medium labels May 10, 2023
@takagi
Copy link
Member

takagi commented May 16, 2023

/test mini

takagi
takagi previously approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@takagi takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mergify
Copy link
Contributor

mergify bot commented May 17, 2023

This pull request is now in conflicts. Could you fix it @ev-br? 🙏

@takagi
Copy link
Member

takagi commented May 18, 2023

/test mini

@takagi takagi added this to the v13.0.0b1 milestone May 26, 2023
@takagi
Copy link
Member

takagi commented May 26, 2023

/test mini

@ev-br
Copy link
Contributor Author

ev-br commented May 26, 2023

Update the testing.with_requires("scipy >= 1.8.0") guards for CZT being new in scipy 1.8.0.

takagi
takagi previously approved these changes May 29, 2023
View reviewed changes
Copy link
Member

@takagi takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@takagi takagi enabled auto-merge May 29, 2023 05:20
@takagi takagi disabled auto-merge May 30, 2023 04:40
@takagi
Copy link
Member

takagi commented May 30, 2023

/test mini

@takagi
Copy link
Member

takagi commented Jun 1, 2023

/test mini

@takagi takagi merged commit 334be4e into cupy:main Jun 6, 2023
@takagi
Copy link
Member

takagi commented Jun 6, 2023

Thanks, @ev-br!

@takagi takagi mentioned this pull request Jun 6, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takagi takagi takagi approved these changes

Assignees

@takagi takagi

Labels
cat:feature New features/APIs prio:medium
Projects
Signal API (CZI EOSS 5)
Status: ✅ Done
Milestone
v13.0.0b1
Development

Successfully merging this pull request may close these issues.
3 participants
@ev-br @takagi @asi1024