Fix input error #161
Merged
Fix input error #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaow
reviewed
Jul 5, 2022
GWAS/liftover.ipynb
Outdated
| @@ -255,11 +255,11 @@ | |||
| " import os.path\n", | |||
| " input_path=${_input[0]:r}\n", | |||
| " output_path=${_output[0]:r}\n", | |||
| " fr = ${fr}\n", | |||
| " to = ${to}\n", | |||
| " fr = f'${fr}'\n", | |||
There was a problem hiding this comment.
Please remove f. There is no need for that I believe.
There was a problem hiding this comment.
I tested the code. removing f causes an error.
There was a problem hiding this comment.
To clarify, you are saying this does not work? I don't think so. Please double check
fr = "${fr}"
(without f but with quote on the string)
gaow
reviewed
Jul 5, 2022
GWAS/liftover.ipynb
Outdated
| @@ -167,7 +167,7 @@ | |||
| "# Rename Variant ID\n", | |||
| "parameter: rename = True\n", | |||
| "# Container\n", | |||
| "parameter: container = str" | |||
| "parameter: container = '.'" | |||
There was a problem hiding this comment.
Please make container default as empty string ''
|
@changebio there is a merge conflict ... please resolve that. |
|
fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.