Rethink URI sanitization

[rywall]

The URI sanitization is starting to get a bit out of hand. I wonder if there is a different approach or if some of this is unnecessary with more modern browsers?

kmz_compressor/app/assets/javascripts/kmz_compressor/map_layer_manager.js

Line 271 in 4ef24aa

function sanitizeURI(uri) {

[njakobsen]

We should probably not decode the entire URI search here

kmz_compressor/app/assets/javascripts/kmz_compressor/map_layer_manager.js

Line 277 in 4ef24aa

search = decodeURIComponent(search).trim().replace(/^\?/, '') // Remove any leading ?

. I believe the decodeURIComponent function is meant to be used on key and value strings, not the contacted search string itself.

[njakobsen]

Maybe we want to rip the URI apart and turn it into an intermediate representation instead of leaving it as a URL that could potentially be affected by browser quirks, and then SHA it.