Skip to content

Added numpadDecimal keycode and fixed unbinding logic #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
zshall wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added numpadDecimal keycode and fixed unbinding logic #1

zshall wants to merge 3 commits into from
+80 −1

Conversation

@zshall
Copy link

@zshall zshall commented Apr 22, 2025 •
edited
Loading

  • Added unit tests for numpad0 thru numpad9
  • Added numpadDecimal key for the . key on the numpad and unit tests
  • Fixed an issue with key unbinding where unassigning multiple keys like unbindKey('/, f'); wasn't functioning properly, as we were only reassigning key if we had multiple keys (using +).

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@zshall