Skip to content

Conversation

fabiot21
Copy link
Contributor

@fabiot21 fabiot21 commented Jul 15, 2023

Added compress prop (ref #32) and logic to handle if grid should vertical compress or not when collision is active. If collision = true and compress = false then:

  • Enables free item movement on the grid.
  • Collision between items leads to relocation of the collided item.
  • The relocation is to the first available space.
  • Grid can dynamically expand on the y-axis if no space is available.
  • Expansion accommodates the relocated item in a new position.

Additionally, a bug has been fixed where the previewItem of items, which had previously collided and been moved, was not updating correctly. This issue occasionally caused certain items to unexpectedly jump to a different position when clicked.

@fabiot21
Copy link
Contributor Author

@cuire anything else i should add to merge this?

@cuire
Copy link
Owner

cuire commented Jul 18, 2023

@cuire anything else i should add to merge this?

Thank you for amazing work. Everything is fantastic. Ill merge it in a few hours.

@cuire cuire merged commit 7519d87 into cuire:main Jul 18, 2023
@cuire cuire mentioned this pull request Jul 21, 2023
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants