Adding dynamic cvv to card #302
Conversation
Codecov Report
@@ Coverage Diff @@
## main #302 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 43 43
Lines 990 994 +4
=========================================
+ Hits 990 994 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
chiqeen03
force-pushed
the
dynamic_cvv
branch
from
485a589 to
ab79ebc
Compare
chiqeen03
force-pushed
the
dynamic_cvv
branch
from
e670b87 to
91e1211
Compare
chiqeen03
force-pushed
the
dynamic_cvv
branch
from
21245cc to
2b55768
Compare
cuenca/resources/cards.py
Outdated
| funding_type: CardFundingType, | ||
| user_id: str = 'me', | ||
| card_holder_user_id: Optional[str] = None, | ||
| is_dynamic_cvv: Optional[bool] = False, |
There was a problem hiding this comment.
Optional solo si el default es None
cuenca/resources/cards.py
Outdated
| card_id: str, | ||
| status: Optional[CardStatus] = None, | ||
| pin_block: Optional[str] = None, | ||
| is_dynamic_cvv: Optional[bool] = False, |
There was a problem hiding this comment.
igual al comentario anterior
cuenca/resources/cards.py
Outdated
| issuer: CardIssuer | ||
| funding_type: CardFundingType | ||
| dcvv: Optional[str] = None | ||
| dcvv_expires_at: Optional[str] = None |
There was a problem hiding this comment.
No te falló? debe ser datetime no?
There was a problem hiding this comment.
no falla, paarece que pydantic convierte lafecha a str
requirements.txt
Outdated
| @@ -1,3 +1,3 @@ | |||
| requests==2.27.1 | |||
| cuenca-validations==0.11.4 | |||
| cuenca-validations==0.11.6.dev0 | |||
There was a problem hiding this comment.
puedes mezclar cuenca validations y ya poner las versiones correctas
pachCode
left a comment
pachCode
left a comment
There was a problem hiding this comment.
También falta regrabar cassette
cuenca/version.py
Outdated
| @@ -1,3 +1,3 @@ | |||
| __version__ = '0.14.6' | |||
| __version__ = '0.14.8.dev0' | |||
There was a problem hiding this comment.
creo que la versión correcta debe sr 0.15.0. No es un bug fix, sino un nuevo feature.
3 participants
No description provided.