Skip to content

Conversation

@alexviquez
Copy link
Contributor

@alexviquez alexviquez commented Jul 4, 2022

Bump cuenca-validations and apply changes of usage TOSRequest

@alexviquez alexviquez added the bug Something isn't working label Jul 4, 2022
@alexviquez alexviquez requested a review from rogelioLpz July 4, 2022 15:49
@alexviquez alexviquez self-assigned this Jul 4, 2022
@codecov
Copy link

codecov bot commented Jul 4, 2022

Codecov Report

Merging #294 (355b975) into main (0fa0d0d) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #294   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           43        43           
  Lines         1010      1010           
=========================================
  Hits          1010      1010           
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cuenca/resources/users.py 100.00% <ø> (ø)
cuenca/version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fa0d0d...355b975. Read the comment docs.

Copy link
Member

@rogelioLpz rogelioLpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Falta el setup para que la minima version sea la version 0.10.18 de. ccuenca-validations

https://github.com/cuenca-mx/cuenca-python/blob/main/setup.py#L28

@alexviquez
Copy link
Contributor Author

@rogelioLpz listo

@alexviquez alexviquez merged commit f258b98 into main Jul 4, 2022
@alexviquez alexviquez deleted the bump-cv branch July 4, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants