python: Remove pipenv #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Makefile mechanism currently patch only the version in "setup.py" * Other file locations are described in ".bumpversion.cfg" file.
If "dotenv" is setup for the shell: * On entering this directory: Setup environemnt variables. * On leaving this directory: Restore the former environemnt state. PREPARED (but: .envrc.*.disabled): * use_venv: Auto-create virtual-environment and activate it. * use_pep0528: Use PEP-0528 "__pypackages__/$(PYTHON_VERSION)/" directory. To enable each part, just removed the ".disabled" suffix. EXAMPLE: Rename ".envrc.use_venv.disabled" to ".envrc.use_venv".
* FIX: Old, broken hyperlinks * Update Python package dependencies * Cleanup and reorganize some stuff
* Use "pip" instead of "pipenv" HINT: "pipenv" caused multiple problems in the CI build in the past. * Newer versions of "pip" support install under $HOME directory. NOTE: This works without "sudo" and is currently preferred. * If an virtual-environment was activated, before using "make", the Python packages are installed into the virtual-environemnt. REFACTORING AND CLEANUP (of: Makefile) * Improve readability and simplify functionality.
github-actions is used as CI build system. Therefore, use the badge for tests passing from this CI. WAS: Still using the CircleCI badge before.
Update the "DEVELOPMENT.rst" file to reflect the changed build procedures and workflow steps.
* Seems to broken due to "pip" * Remove "py27" from "envlist" for now. NOTES: * Can still create a virtual-environment for Python 2.7 * Can still run the tests in virtual-environment * Added more scripts to simplify setup of virtual-environment CLEANUP: In Makefile, invoke * Remove get-pip.py
* Only support for python.version >= 3.7
* Improved version of "tasks/_tasklet_cleanup.py" * On cleanup/cleanup.all: Skips SUICIDE of own virtual-encironment should be deleted.
| ------------------------------------------------------------------------------- | ||
|
|
||
| `direnv`_ simplifies the setup and cleanup of environment variables. | ||
| If `direnv`_ is setup: |
| # (for Python) in the HOME directory of the user (for this directory). | ||
| # This makefile uses "pip" to automatically install the required packages: | ||
| # | ||
| # * CASE 1: If a Python a virtual environment was setup and activated, |
olleolleolle
approved these changes
Mar 14, 2022
jenisys
added a commit
to jenisys/cucumber.tag-expressions
that referenced
this pull request
Mar 14, 2022
* make install-packages: Improve make output and make it more readable. * Correct small wording/spelling mistakes comments and docs (mentioned by: @olleolleolle in review of PR cucumber#45).
This was referenced Mar 14, 2022
jenisys
added a commit
that referenced
this pull request
Mar 14, 2022
* make install-packages: Improve make output and make it more readable. * Correct small wording/spelling mistakes comments and docs (mentioned by: @olleolleolle in review of PR #45).
jenisys
added a commit
to jenisys/cucumber.tag-expressions
that referenced
this pull request
Mar 14, 2022
* FIX: cucumber-tag-expression in some places. * Makefile mechanism currently patch only the version in "setup.py" * Other file locations are described in ".bumpversion.cfg" file. * PYTHON: Simplify project environment setup with "direnv". If "dotenv" is setup for the shell: * On entering this directory: Setup environemnt variables. * On leaving this directory: Restore the former environemnt state. PREPARED (but: .envrc.*.disabled): * use_venv: Auto-create virtual-environment and activate it. * use_pep0528: Use PEP-0528 "__pypackages__/$(PYTHON_VERSION)/" directory. To enable each part, just removed the ".disabled" suffix. EXAMPLE: Rename ".envrc.use_venv.disabled" to ".envrc.use_venv". * PYTHON: setup: Fix some hyperlinks * FIX: Old, broken hyperlinks * Update Python package dependencies * Cleanup and reorganize some stuff * PYTHON: Remove the use of "pipenv" * Use "pip" instead of "pipenv" HINT: "pipenv" caused multiple problems in the CI build in the past. * Newer versions of "pip" support install under $HOME directory. NOTE: This works without "sudo" and is currently preferred. * If an virtual-environment was activated, before using "make", the Python packages are installed into the virtual-environemnt. REFACTORING AND CLEANUP (of: Makefile) * Improve readability and simplify functionality. * PYTHON: Fix the CI build badge github-actions is used as CI build system. Therefore, use the badge for tests passing from this CI. WAS: Still using the CircleCI badge before. * PYTHON: Update the developer docs. Update the "DEVELOPMENT.rst" file to reflect the changed build procedures and workflow steps. * PYTHON: Try to fix "tox" for Python 2.7 * Seems to broken due to "pip" * Remove "py27" from "envlist" for now. NOTES: * Can still create a virtual-environment for Python 2.7 * Can still run the tests in virtual-environment * Added more scripts to simplify setup of virtual-environment CLEANUP: In Makefile, invoke * Remove get-pip.py * PYTHON: FIX dependency for "bandit" * Only support for python.version >= 3.7 * PYTHON: Use invoke_cleanup * Improved version of "tasks/_tasklet_cleanup.py" * On cleanup/cleanup.all: Skips SUICIDE of own virtual-encironment should be deleted.
jenisys
added a commit
to jenisys/cucumber.tag-expressions
that referenced
this pull request
Mar 14, 2022
* make install-packages: Improve make output and make it more readable. * Correct small wording/spelling mistakes comments and docs (mentioned by: @olleolleolle in review of PR cucumber#45).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
Refactoring of Python implementation of
tag-expressionsto remove the use ofpipenv.This is part 2 of the removal that removes the use of
pipenvfrom theMakefile, etc. (build system related).RELATED:
OTHERWISE:
dotenvto simplify setup of environment variables whenpython/directory is entered.python/directory.FIXES:
setup.pyoutdated URLs due to old repository (same change as PR Fix broken url in python package metadata #29).package.versionsto4.1.0(was:4.0.2).REASON: These package.version parts are currently not updated by
Makefilewhen version is bumped.test-pythonCI build workflow to use GitHub-actions (was: Using old CircleCI badge).py27virtual environment fromenvlistuntil it is really fixed.⚡️ What's your motivation?
The CI build problem related to PR #40 .
This triggered the refactoring, update and cleanups in the project's build system.
🏷️ What kind of change is this?
📋 Checklist:
DEVELOPMENT.rst, README.rst`).