Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] Fix release workflow for Python #146

Merged
merged 1 commit into from
Jan 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[Python] Fix release workflow for Python
Polyglot-release cannot handle the version in setup.py if a file
pyproject.toml exist in the Python project.
Need to specify the packages-dir for
pypa/gh-action-pypi-publish@release/v1
  • Loading branch information
brasmusson committed Jan 7, 2024
commit 074911af10e2aa18cc06e4ebd484e90d07cc60b9
5 changes: 3 additions & 2 deletions .github/workflows/release-pypi.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,16 +28,17 @@ jobs:

- name: Install Python package dependencies
run: |
python -m pip install -U pip setuptools wheel twine build
python -m pip install -U pip setuptools wheel twine
pip install -e .

- name: Build dist
run: python -m build .
run: python setup.py sdist bdist_wheel

- name: Check dist
run: twine check dist/*

- name: Publish package distributions to PyPI
uses: pypa/gh-action-pypi-publish@release/v1
with:
packages-dir: python/dist/
skip-existing: true
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
- [Python] Support the feature of escaping also in Python ([#144](https://github.com/cucumber/tag-expressions/pull/144))

### Fixed
- [Python] Added workflow to release to Pypi ([#145](https://github.com/cucumber/tag-expressions/pull/145))
- [Python] Added workflow to release to Pypi ([#145](https://github.com/cucumber/tag-expressions/pull/145), [#146](https://github.com/cucumber/tag-expressions/pull/146), [#20](https://github.com/cucumber/tag-expressions/issues/20))
- [Ruby] Fixed up around 75% of all rubocop offenses ([#138](https://github.com/cucumber/tag-expressions/pull/138))

## [6.0.0] - 2023-10-13
Expand Down
5 changes: 0 additions & 5 deletions python/pyproject.toml

This file was deleted.

Loading