Skip to content

Apply URI based sorting for the displayed gherkin documents #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 7, 2025

Conversation

gasparnagy
Copy link
Member

@gasparnagy gasparnagy commented Aug 6, 2025

🤔 What's changed?

Applied an URI-based sorting on the displayed documents, based on the suggestion of @mpkorstanje at #392 (comment).

⚡️ What's your motivation?

Fixes #392

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

♻️ Anything particular you want feedback on?

Currently this uses a case-insensitive full URI comparison, so it produces a list, like this:

          'Features/a.feature',
          'Features/B.feature',
          'Features/c.feature',
          'Features/d/e.feature',
          'Features/f.feature',

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

Copy link

netlify bot commented Aug 6, 2025

Deploy Preview for cucumber-react-preview ready!

Name Link
🔨 Latest commit 6fc3be4
🔍 Latest deploy log https://app.netlify.com/projects/cucumber-react-preview/deploys/6894c5ed300c4700081100e5
😎 Deploy Preview https://deploy-preview-394--cucumber-react-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@gasparnagy gasparnagy marked this pull request as ready for review August 6, 2025 16:45
@davidjgoss davidjgoss merged commit 68845ab into main Aug 7, 2025
6 checks passed
@davidjgoss davidjgoss deleted the uri-based-sorting branch August 7, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sort features by folders and feature name
2 participants